Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for interfaces/webtransport.idl #22852

Merged
merged 3 commits into from May 20, 2021
Merged

Conversation

stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Apr 10, 2020

Closes #25764

@wpt-pr-bot wpt-pr-bot requested a review from foolip April 10, 2020 12:02
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-22852 April 10, 2020 12:07 Inactive
@foolip
Copy link
Member

foolip commented Apr 20, 2020

@stephenmcgruer have you checked the wpt-chrome-dev-stability failure? Feel free to merge if it's bogus.

@stephenmcgruer
Copy link
Contributor Author

Ooo, it's flaky, fun!

 0:42.54 INFO ## Unstable results ##
 0:42.54 INFO |                 Test                 | Subtest |          Results          | Messages |
 0:42.54 INFO |--------------------------------------|---------|---------------------------|----------|
 0:42.54 INFO | `/web-transport/idlharness.any.html` |         | **ERROR: 9/10, OK: 1/10** |          |

Ah, there's a race in whether the QuicTransport class realizes there's no connection I think; ERROR /web-transport/idlharness.any.html - Unhandled rejection: Connection lost..

To do properly we need the QUIC server up. Since that's coming soon, I think I'm going to punt on this till then, sorry for pinging you over it too early.

@foolip
Copy link
Member

foolip commented May 18, 2020

@stephenmcgruer the QUIC server exists now, right?

@stephenmcgruer
Copy link
Contributor Author

@Hexcles - is the quic server usable now?

Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not enabled yet because of a cert issue.

Regardless, this test should have a label and be skipped if the QUIC server isn't available.

web-transport/idlharness.any.js Outdated Show resolved Hide resolved
@stephenmcgruer
Copy link
Contributor Author

Regardless, this test should have a label and be skipped if the QUIC server isn't available.

Ack, but I sorta need the quic server available to develop the test 😆

@Hexcles
Copy link
Member

Hexcles commented May 19, 2020

Oh I guess you'd need to wait just a bit longer then :)

Besides, I'm not even sure QUIC is enabled on the Chrome side even with --enable-experimental-web-platform-features. There were a couple of more flags needed according to #22844 (comment)

@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Sep 21, 2020

@Hexcles What's are the plans on making QUIC available for wpt.fyi runs? Looks like these all get marked SKIP with the quic flag added (note that the test still needs work, but little point if they're just going to be skipped ;)).

EDIT: s/h2/quic

@Hexcles
Copy link
Member

Hexcles commented Sep 21, 2020

This is blocked by w3c/webtransport#125

Currently this only tests QuicTransport and Http3Transport, as the
streams require that you have a working connection to create.
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip
Copy link
Member

foolip commented May 19, 2021

@foolip
Copy link
Member

foolip commented May 20, 2021

@foolip foolip changed the title Add interfaces/web-transport.idl and test Add test for interfaces/webtransport.idl May 20, 2021
@foolip foolip dismissed Hexcles’s stale review May 20, 2021 14:36

QUIC avoided, left as TODO

@foolip foolip merged commit b1659d0 into master May 20, 2021
@foolip foolip deleted the smcgruer/web-transport branch May 20, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants