New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for interfaces/webtransport.idl #22852
Conversation
@stephenmcgruer have you checked the wpt-chrome-dev-stability failure? Feel free to merge if it's bogus. |
Ooo, it's flaky, fun!
Ah, there's a race in whether the QuicTransport class realizes there's no connection I think; To do properly we need the QUIC server up. Since that's coming soon, I think I'm going to punt on this till then, sorry for pinging you over it too early. |
@stephenmcgruer the QUIC server exists now, right? |
@Hexcles - is the quic server usable now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not enabled yet because of a cert issue.
Regardless, this test should have a label and be skipped if the QUIC server isn't available.
Ack, but I sorta need the quic server available to develop the test 😆 |
Oh I guess you'd need to wait just a bit longer then :) Besides, I'm not even sure QUIC is enabled on the Chrome side even with |
1a89285
to
d26102a
Compare
@Hexcles What's are the plans on making QUIC available for wpt.fyi runs? Looks like these all get marked EDIT: s/h2/quic |
This is blocked by w3c/webtransport#125 |
Currently this only tests QuicTransport and Http3Transport, as the streams require that you have a working connection to create.
d26102a
to
1382b90
Compare
There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
Hmm, this is still SKIP on wpt.fyi: https://wpt.fyi/results/webtransport/idlharness.any.html?label=pr_head&max-count=1&pr=22852 |
The test now works enough to be useful: https://wpt.fyi/results/webtransport/idlharness.any.html?label=pr_head&max-count=1&pr=22852 |
Closes #25764