Introduce test infrastructure for QuicTransport #22844

yutakahirano · 2020-04-10T08:21:43Z

This change introduces test infrastructure for
QuicTransport.
See also: https://github.com/web-platform-tests/rfcs/blob/master/rfcs/quic.md

tools/quic contains the test server and files needed by the server such as certificate files.
tools/quic/quic_transport_server.py is based on
https://github.com/aiortc/aioquic/blob/master/examples/http3_server.py.

webtransport/quic contains a test example. It also contains a sample custom handler.

This change doesn't contain a means to run the QuicTransport server automatically.

Tracking issue: #19114

yutakahirano · 2020-04-10T08:31:11Z

@Hexcles, what do you think about this?

@ricea @aboba @vasilvv: Can you take a look at the webtransport/quic part?

I tested this with manually running the server,

$ python3 tools/quic/quic_transport_server.py --certificate tools/quic/certs/leaf_cert.pem --port=8983 --private-key=tools/quic/certs/leaf_cert.key --handlers-path=webtransport/quic/handlers

...and giving additional command line flags to Chrome.

--enable-quic
--quic-version=h3-25
--origin-to-force-quic-on=web-platform.test:8983
--ignore-certificate-errors-spki-list=NkfjIFsVoBC1WJSWcwLhG9BslR544io9SI2oeLbvA7I=

yutakahirano · 2020-04-10T08:48:58Z

@vasilvv: I'd appreciate your review on quic_transport_server.py too.

webtransport/quic/handlers/client-indication.py

webtransport/quic/client-indication.any.js

tools/quic/quic_transport_server.py

webtransport/quic/client-indication.any.js

webtransport/quic/handlers/client-indication.quic.py

ricea · 2020-04-13T11:26:27Z

webtransport/quic/handlers/client-indication.quic.py

+async def notify(connection):
+    _, writer = await connection.create_stream(is_unidirectional=True)
+    writer.write(b'PASS')
+    writer.write_eof()


Is connection ever closed? Do we need to close it?

It's not closed, and I don't think it needs to be closed in this case.

tools/quic/certs/leaf_cert.pem

Hexcles

I'm preparing the infra code:
#23075 sets up the venv
#23078 fixes the tests

There's going to be a small number of merge conflicts but hopefully tests will pass after they land.

tools/quic/requirements.txt

Hexcles · 2020-04-21T23:32:11Z

I'm preparing the infra code:
#23075 sets up the venv
#23078 fixes the tests

There's going to be a small number of merge conflicts but hopefully tests will pass after they land.

Both PRs have landed! @yutakahirano could you do a git merge --squash master on your branch? Hopefully this will eliminate the lint errors.

Co-Authored-By: Robert Ma <robertma@chromium.org>

yutakahirano · 2020-04-30T10:57:26Z

Sorry for the late response. This now pass checks.

For the certificate issue I filed aiortc/aioquic#89.

@ricea @aboba @vasilvv do you have more review comments?

vasilvv

LGTM, with exception of one minor comment.

tools/quic/quic_transport_server.py

ricea

lgtm

webtransport/quic/handlers/client-indication.quic.py

Hexcles

This is looking great!

Hexcles · 2020-05-01T20:48:45Z

tools/quic/certs/README.md

@@ -0,0 +1,12 @@
+To generate cert.key and cert.pem:


IIUC, once aiortc/aioquic#89 is fixed, we can use web-platform.test.{key,pem} directly?

We can do that.

An implication is that the QUIC server will be relatively self contained, without dependencies on other modules in wpt that are currently Python 2-only.

https://github.com/web-platform-tests/rfcs/blob/master/rfcs/quic.md

does not apply to certificate files, right?

It's OK to use the cert in tools/cert. We could perhaps keep the certs in tools/quic/certs as well but only as a fallback.

Hexcles · 2020-05-01T21:17:00Z

tools/quic/quic_transport_server.py

+    )
+    try:
+        loop.run_forever()
+    except KeyboardInterrupt:


Question: is there any cleanup that's required? Like releasing the port?

If so, we'd also need to catch SIGTERM and SIGINT (which is different from KeyboardInterrupt, which I think is only raised after interactive Ctrl-C), and exit gracefully.

@yutakahirano I took a look and I don't think any cleanup is needed here. There's no subprocess, and the UDP port gets released almost immediately if the process is killed (unlike TCP ports).

Hexcles

Looks like we still haven't got a new aioquic release yet. Nonetheless, I'm going to merge this PR for now so that I can build some final pieces of intergration.

yutakahirano · 2020-05-13T10:31:21Z

Sorry for the late response, and thank you for merging this. I'll address the remaining comments in followup PRs.

Address comments provided in #22844.

* [QuicTransport] Address comments in pull/22844 Address comments provided in #22844.

…/22844, a=testonly Automatic update from web-platform-tests [QuicTransport] Address comments in pull/22844 (#23705) * [QuicTransport] Address comments in pull/22844 Address comments provided in web-platform-tests/wpt#22844. -- wpt-commits: 6e5e590ef6d34a2cdbc04bbc493d34e482db1d77 wpt-pr: 23705

wpt-pr-bot added infra quic webtransport labels Apr 10, 2020

wpt-pr-bot assigned Hexcles Apr 10, 2020

wpt-pr-bot requested review from Hexcles, jgraham, KyleJu, LukeZielinski and stephenmcgruer April 10, 2020 08:21

wpt-pr-bot temporarily deployed to wpt-preview-22844 April 10, 2020 08:23 Inactive

wpt-pr-bot temporarily deployed to wpt-preview-22844 April 10, 2020 08:49 Inactive

wpt-pr-bot temporarily deployed to wpt-preview-22844 April 10, 2020 10:14 Inactive

Hexcles reviewed Apr 10, 2020

View reviewed changes

webtransport/quic/handlers/client-indication.py Outdated Show resolved Hide resolved

webtransport/quic/client-indication.any.js Show resolved Hide resolved

tools/quic/quic_transport_server.py Show resolved Hide resolved

wpt-pr-bot temporarily deployed to wpt-preview-22844 April 13, 2020 04:34 Inactive

wpt-pr-bot temporarily deployed to wpt-preview-22844 April 13, 2020 05:08 Inactive

ricea reviewed Apr 13, 2020

View reviewed changes

wpt-pr-bot temporarily deployed to wpt-preview-22844 April 14, 2020 06:59 Inactive

Hexcles reviewed Apr 15, 2020

View reviewed changes

tools/quic/certs/leaf_cert.pem Outdated Show resolved Hide resolved

Hexcles mentioned this pull request Apr 17, 2020

Tweak lints and checks for tools/quic #23078

Merged

Hexcles reviewed Apr 17, 2020

View reviewed changes

tools/quic/requirements.txt Outdated Show resolved Hide resolved

wpt-pr-bot added the wptserve label Apr 20, 2020

wpt-pr-bot temporarily deployed to wpt-preview-22844 April 20, 2020 11:39 Inactive

yutakahirano added 5 commits April 30, 2020 18:27

initial

91bac96

format

ecee5cd

fix

d68e220

fix

f05892b

fix

7d3ace3

yutakahirano and others added 10 commits April 30, 2020 18:28

fix

36162ac

fix

659a415

fix

f0035ac

fix

072ae3d

fix

7f43a99

Update webtransport/quic/client-indication.any.js

aec45c6

Co-Authored-By: Robert Ma <robertma@chromium.org>

Update tools/quic/quic_transport_server.py

3e1c2fd

Co-Authored-By: Robert Ma <robertma@chromium.org>

fix

bae3e52

fix

68d7a66

fix

25182ba

yutakahirano force-pushed the yhirano/quic-server branch from 25e8cf1 to 25182ba Compare April 30, 2020 09:33

wpt-pr-bot temporarily deployed to wpt-preview-22844 April 30, 2020 09:40 Inactive

fix

f93fa01

wpt-pr-bot deployed to wpt-preview-22844 April 30, 2020 10:14 View deployment

vasilvv approved these changes May 1, 2020

View reviewed changes

tools/quic/quic_transport_server.py Show resolved Hide resolved

ricea approved these changes May 1, 2020

View reviewed changes

webtransport/quic/handlers/client-indication.quic.py Show resolved Hide resolved

Hexcles reviewed May 1, 2020

View reviewed changes

Hexcles approved these changes May 12, 2020

View reviewed changes

Hexcles merged commit 512cf24 into master May 12, 2020

Hexcles deleted the yhirano/quic-server branch May 12, 2020 21:13

Hexcles mentioned this pull request May 19, 2020

Add test for interfaces/webtransport.idl #22852

Merged

yutakahirano added a commit that referenced this pull request May 20, 2020

[QuicTransport] Address comments in pull/22844

d0d817c

Address comments provided in #22844.

yutakahirano mentioned this pull request May 20, 2020

[QuicTransport] Address comments in pull/22844 #23705

Merged

yutakahirano added a commit that referenced this pull request May 20, 2020

[QuicTransport] Address comments in pull/22844 (#23705)

6e5e590

* [QuicTransport] Address comments in pull/22844 Address comments provided in #22844.

This was referenced May 5, 2021

Incrementally expanding the use of mypy #28833

Closed

Enable mypy for tools/quic/ #28916

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce test infrastructure for QuicTransport #22844

Introduce test infrastructure for QuicTransport #22844

yutakahirano commented Apr 10, 2020 •

edited by Hexcles

Loading

yutakahirano commented Apr 10, 2020

yutakahirano commented Apr 10, 2020

ricea Apr 13, 2020

yutakahirano Apr 14, 2020

Hexcles left a comment

Hexcles commented Apr 21, 2020

yutakahirano commented Apr 30, 2020

vasilvv left a comment

ricea left a comment

Hexcles left a comment

Hexcles May 1, 2020

yutakahirano May 13, 2020

Hexcles May 13, 2020

Hexcles May 1, 2020

Hexcles May 15, 2020

Hexcles left a comment

yutakahirano commented May 13, 2020

Introduce test infrastructure for QuicTransport #22844

Introduce test infrastructure for QuicTransport #22844

Conversation

yutakahirano commented Apr 10, 2020 • edited by Hexcles Loading

yutakahirano commented Apr 10, 2020

yutakahirano commented Apr 10, 2020

ricea Apr 13, 2020

Choose a reason for hiding this comment

yutakahirano Apr 14, 2020

Choose a reason for hiding this comment

Hexcles left a comment

Choose a reason for hiding this comment

Hexcles commented Apr 21, 2020

yutakahirano commented Apr 30, 2020

vasilvv left a comment

Choose a reason for hiding this comment

ricea left a comment

Choose a reason for hiding this comment

Hexcles left a comment

Choose a reason for hiding this comment

Hexcles May 1, 2020

Choose a reason for hiding this comment

yutakahirano May 13, 2020

Choose a reason for hiding this comment

Hexcles May 13, 2020

Choose a reason for hiding this comment

Hexcles May 1, 2020

Choose a reason for hiding this comment

Hexcles May 15, 2020

Choose a reason for hiding this comment

Hexcles left a comment

Choose a reason for hiding this comment

yutakahirano commented May 13, 2020

yutakahirano commented Apr 10, 2020 •

edited by Hexcles

Loading