Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 2d.getImageData.* in canvas_api to wpt #23163

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 22, 2020

Move 2d.getImageData.* from canvas_api to wpt.

Bug: 1071659

Change-Id: I444088c44eb6f93d4800175deef05f99bfc8e98c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159913
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763137}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@foolip
Copy link
Member

foolip commented Apr 28, 2020

The update-built step has failed on Taskcluster with this error:

--- a/2dcontext/pixel-manipulation/2d.imageData.get.rounding.html
+++ b/2dcontext/pixel-manipulation/2d.imageData.get.rounding.html
@@ -26,18 +26,18 @@ function testDimensions(sx, sy, sw, sh, width, height)
     _assert(imageData.height == height, "imageData.height == height");
 }
 
-testDimensions(   0,  0,   20,  10,     20, 10);
+testDimensions(0, 0, 20, 10, 20, 10);
 
-testDimensions(  .1, .2,   20,  10,     20, 10);
-testDimensions(  .9, .8,   20,  10,     20, 10);
+testDimensions(.1, .2, 20, 10, 20, 10);
+testDimensions(.9, .8, 20, 10, 20, 10);
 
-testDimensions(   0,  0, 20.9, 10.9,     20, 10);
-testDimensions(   0,  0, 20.1, 10.1,     20, 10);
+testDimensions(0, 0, 20.9, 10.9, 20, 10);
+testDimensions(0, 0, 20.1, 10.1, 20, 10);
 
-testDimensions(  -1, -1,   20,  10,     20, 10);
+testDimensions(-1, -1, 20, 10, 20, 10);
 
-testDimensions(-1.1,  0,   20,  10,     20, 10);
-testDimensions(-1.9,  0,   20,  10,     20, 10);
+testDimensions(-1.1, 0, 20, 10, 20, 10);
+testDimensions(-1.9,  0, 20, 10, 20, 10);

Move 2d.getImageData.* from canvas_api to wpt.

Bug: 1071659

Change-Id: I444088c44eb6f93d4800175deef05f99bfc8e98c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159913
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763137}
@foolip foolip force-pushed the chromium-export-cl-2159913 branch from 1c7a2be to f4f2bff Compare April 28, 2020 10:05
@foolip
Copy link
Member

foolip commented Apr 28, 2020

Since it's just whitespace changes I've applied them and pushed.

@foolip
Copy link
Member

foolip commented Apr 28, 2020

wpt-firefox-nightly-results-without-changes is still running, but this is blocking another Chromium export so I'm going to admin merge it now.

@foolip foolip merged commit 9d33bb0 into master Apr 28, 2020
@foolip foolip deleted the chromium-export-cl-2159913 branch April 28, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants