Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3 and python3-pip to the docker image #23190

Merged
merged 3 commits into from Apr 23, 2020
Merged

Conversation

stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Apr 22, 2020

These dependencies are required to run the CI system under Python 3, including making distutils available.

See #23182 (comment)

@Hexcles
Copy link
Member

Hexcles commented Apr 22, 2020

Re "Get a Docker Hub account. Build and push the image.", the README isn't clear if you've never used Docker Hub before.

The tag should be of the form [USERNAME]/web-platform-tests:[CURRENT_VERSION+0.01]. (The repo name doesn't have to be web-platform-tests; it's just a convention.)

And I just realized that I had created an organization on Docker Hub before but never used it, so let me give it a try.

stephenmcgruer added a commit that referenced this pull request Apr 22, 2020
This incorporates the change in
#23190, as well as
switching to the new dockerhub organization.
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-23190 April 22, 2020 23:38 Inactive
Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps also add a reminder to update .taskcluster.yml.

tools/docker/README.md Outdated Show resolved Hide resolved
tools/docker/README.md Outdated Show resolved Hide resolved
@Hexcles Hexcles merged commit cbb6f67 into master Apr 23, 2020
@Hexcles Hexcles deleted the smcgruer/docker_update branch April 23, 2020 15:56
Hexcles added a commit that referenced this pull request Apr 23, 2020
This is a follow-up to #23190. I forgot that tools/ci/tc/tasks/test.yml
existed, so we really only updated the image of the decision task.

Drive-by:
* Update README to document this.
* Remove python3-pip from `install` as it's now included in the image.
Hexcles added a commit that referenced this pull request Apr 23, 2020
This is a follow-up to #23190. I forgot that tools/ci/tc/tasks/test.yml
existed, so we really only updated the image of the decision task.

Drive-by:
* Update README to document this.
* Remove python3-pip from `install` as it's now included in the image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants