[WPT] Test script's base URL used in dynamic imports #23560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 13, 2020
youennf
reviewed
Jun 15, 2020
| <title>Base URLs used in resolving specifiers in dynamic imports</title> | ||
| <script src="/resources/testharness.js"></script> | ||
| <script src="/resources/testharnessreport.js"></script> | ||
| <script src="/common/redirect.py?location=http://{{domains[www1]}}:{{ports[http][0]}}/html/semantics/scripting-1/the-script-element/module/dynamic-import/scripts/base-url.js"></script> |
There was a problem hiding this comment.
Can we use hosts[alt] instead of domains[www1]
There was a problem hiding this comment.
Done (used hosts[alt][]).
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2198835
branch
3 times, most recently
from
67b7a0a
to
4155c8c
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2198835
branch
2 times, most recently
from
d1890b6
to
365efed
Compare
3 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2198835
branch
2 times, most recently
from
e4f5577
to
0e1bb0f
Compare
This CL checks base URL used in resolving relative URL-like specifiers in dynamic imports() from - `<script>`s, - worker top-level scripts, and - worker scripts imported by `importScripts()`. This is for whatwg/html#5751. Bug: 1082086 Change-Id: I778fb4d34b2e61f57799600006963c93aee5272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198835 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#794492}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2198835
branch
from
0e1bb0f
to
82ef69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL checks base URL used in resolving relative URL-like
specifiers in dynamic imports() from
\<script>s,importScripts().This is for whatwg/html#5751.
Bug: 1082086
Change-Id: I778fb4d34b2e61f57799600006963c93aee5272c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198835
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794492}