New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize classic script's base URL when muted errors flag is set #5753

Merged

domenic merged 2 commits into whatwg:master from hiroshige-g:SanitizeClassicScriptBaseURL

Jul 24, 2020

Contributor

hiroshige-g commented Jul 22, 2020 •

edited by domenic

Fixes #5751.

At least two implementers are interested (and none opposed):
- Discussed with Chromium(@domenic @nyaxt)/Firefox(@annevk)/Safari(@youennf) people and reached a concensus.
Tests are written and can be reviewed and commented upon at:
- [WPT] Test script's base URL used in dynamic imports web-platform-tests/wpt#23560
Implementation bugs are filed:
- Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1082086
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1646034
- Safari: https://bugs.webkit.org/show_bug.cgi?id=214754

(See WHATWG Working Mode: Changes for more details.)

/webappapis.html ( diff )

hiroshige-g and others added 2 commits

July 22, 2020 16:20


          Sanitize classic script's base URL to about:blank when muted errors f…

d2cadb6

…lag is set

Fixes whatwg#5751.


          Editorial tweaks

5b8bbb3

domenic approved these changes

View reviewed changes

Member

domenic left a comment

LGTM. Will give folks a couple days to comment, then merge.

domenic added normative change topic: script labels

domenic merged commit ac285c0 into whatwg:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment