Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix anonymous-block child-available-size. #24396

Merged
merged 1 commit into from Jul 1, 2020

Commits on Jul 1, 2020

  1. [LayoutNG] Fix anonymous-block child-available-size.

    The logic introduced for CalculateChildAvailableSize was designed to
    have the correct value for an element with:
    "<div style="position: relative; left: 50%; top: 50%;></div>"
    
    E.g. the percentage based left/top would resolve against the available
    size. However this broke text alignment within anonymous-blocks which
    require the child-available-size to be based on the actual inline-size.
    
    This patch uses the actual inline-size in the inline direction, but
    keeps the logic for block direction.
    
    This will mean that for postiion:relative calculations we'll use
    the Percentage inline-size, and Available block-size for resolving
    percentages.
    
    Bug: 1100203
    Change-Id: I83c5281c5de9f9fd40f1bfed54e627dff5bb0600
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274359
    Reviewed-by: David Grogan <dgrogan@chromium.org>
    Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#784323}
    bfgeek authored and chromium-wpt-export-bot committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    4d39914 View commit details
    Browse the repository at this point in the history