[webnfc] Do not support multiple scans on the same reader. #24587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 14, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2297559
branch
3 times, most recently
from
b787a9c
to
a862807
Compare
We added support for multiple scan invocations on the same Reader in this CL https://chromium-review.googlesource.com/c/chromium/src/+/2145263 Since Origin Trials feedback was to remove Filtering, spec : w3c/web-nfc#565 WIP CL : https://chromium-review.googlesource.com/c/chromium/src/+/2225770/ we tried to reason if in a world without filtering, multiple scans on the same Reader is needed at all. The present thinking is to simply reject scan promise when there's already an ongoing scan. Spec discussions: w3c/web-nfc#592 Bug: 520391 Change-Id: Ic50873ddc30351cec6656ac7b030394dc9fa18ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297559 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#790438}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2297559
branch
from
a862807
to
1df6614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added support for multiple scan invocations on the same Reader in
this CL https://chromium-review.googlesource.com/c/chromium/src/+/2145263
Since Origin Trials feedback was to remove Filtering,
spec : w3c/web-nfc#565
WIP CL : https://chromium-review.googlesource.com/c/chromium/src/+/2225770/
we tried to reason if in a world without filtering, multiple scans on
the same Reader is needed at all. The present thinking is to simply
reject scan promise when there's already an ongoing scan.
Spec discussions: w3c/web-nfc#592
Bug: 520391
Change-Id: Ic50873ddc30351cec6656ac7b030394dc9fa18ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297559
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790438}