New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3: Port tests in fetch/api [part 2] #24624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one tiny nit.
@@ -1,13 +1,15 @@ | |||
import time | |||
|
|||
from six.moves import xrange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use range instead if that works across both.
Wait, why do we need to import range? |
'xrange' is not defined in Python 3, it's renamed as 'range' If we can change original 'xrange' to 'range' in the line, I think we can remove the six import line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's what I meant. Thanks!
No description provided.