Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT] Add tests for Worker.terminate() during worker script evaluation #25004

Merged
merged 1 commit into from Sep 18, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 14, 2020

workers/Worker-terminate-forever.html
terminates workers just after construction, and thus it's likely
that the workers are terminated before script evaluation is started.

This CL adds Worker-terminate-forever-during-evaluation.html
that waits for postMessage(), to ensure the worker is terminated
after script evaluation is started.

Bug: 1111134, 1129785
Change-Id: I9ebc8effe6234a297e0851042f5de41f611d55aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355160
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808304}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Loading

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [WPT] Add a test for Worker.terminate() during worker script evaluation [WPT] Add tests for Worker.terminate() during worker script evaluation Sep 15, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2355160 branch 5 times, most recently from 6177adc to c60cc88 Sep 18, 2020
workers/Worker-terminate-forever.html
terminates workers just after construction, and thus it's likely
that the workers are terminated before script evaluation is started.

This CL adds Worker-terminate-forever-during-evaluation.html
that waits for postMessage(), to ensure the worker is terminated
after script evaluation is started.

Bug: 1111134, 1129785
Change-Id: I9ebc8effe6234a297e0851042f5de41f611d55aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355160
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808304}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2355160 branch from c60cc88 to fefea06 Sep 18, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit d1c3245 into master Sep 18, 2020
17 of 19 checks passed
Loading
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2355160 branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants