Test non-special URLs are idempotent #25113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/url#415 and whatwg/url#505 for context.
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest and
TimothyGu
3 tasks
domenic
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Confirmed using jsdom/whatwg-url that these fail before whatwg/url#505 and pass afterward.
annevk
added a commit
to whatwg/url
that referenced
this pull request
Aug 24, 2020
Adjust the URL serializer so it does not output something which during the next parse operation would yield a host. whatwg-url: jsdom/whatwg-url#148. Tests: web-platform-tests/wpt#25113. Fixes #415.
This was referenced Aug 24, 2020
3 tasks
watilde
added a commit
to watilde/node
that referenced
this pull request
Sep 16, 2020
Fixes: nodejs#34899 Refs: whatwg/url#505 Refs: web-platform-tests/wpt#25113
watilde
added a commit
to nodejs/node
that referenced
this pull request
Sep 20, 2020
Fixes: #34899 Refs: whatwg/url#505 Refs: web-platform-tests/wpt#25113 PR-URL: #34925 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Fixes: nodejs#34899 Refs: whatwg/url#505 Refs: web-platform-tests/wpt#25113 PR-URL: nodejs#34925 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/url#415 and whatwg/url#505 for context.