[fetch] Empty destination should be the empty string, not "empty" #25224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 25, 2020
As specified at [1],the empty destination should be the empty string, not "empty". We use "empty" for the "sec-fetch-dest" header[2] though. Fix the implementation and fix incorrect WPTs altogether. 1: https://fetch.spec.whatwg.org/#concept-request-destination 2: https://w3c.github.io/webappsec-fetch-metadata/#abstract-opdef-set-dest Bug: 1121493 Change-Id: Ia86d716dd434c3b6b0e6f1914019fd6110a7ab8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374725 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#801368}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2374725
branch
from
977ac49
to
98bef9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified at [1],the empty destination should be the empty string,
not "empty". We use "empty" for the "sec-fetch-dest" header[2] though.
Fix the implementation and fix incorrect WPTs altogether.
1: https://fetch.spec.whatwg.org/#concept-request-destination
2: https://w3c.github.io/webappsec-fetch-metadata/#abstract-opdef-set-dest
Bug: 1121493
Change-Id: Ia86d716dd434c3b6b0e6f1914019fd6110a7ab8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374725
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801368}