Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fetch] Empty destination should be the empty string, not "empty" #25224

Merged
merged 1 commit into from Aug 25, 2020
Merged

[fetch] Empty destination should be the empty string, not "empty" #25224

merged 1 commit into from Aug 25, 2020

Commits on Aug 25, 2020

  1. [fetch] Empty destination should be the empty string, not "empty" 

    As specified at [1],the empty destination should be the empty string,
not "empty". We use "empty" for the "sec-fetch-dest" header[2] though.

Fix the implementation and fix incorrect WPTs altogether.

1: https://fetch.spec.whatwg.org/#concept-request-destination
2: https://w3c.github.io/webappsec-fetch-metadata/#abstract-opdef-set-dest

Bug: 1121493
Change-Id: Ia86d716dd434c3b6b0e6f1914019fd6110a7ab8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374725
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801368}
    @yutakahirano @chromium-wpt-export-bot
    yutakahirano authored and chromium-wpt-export-bot committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    98bef9b View commit details
    Browse the repository at this point in the history