Python3: make newly introduced python file Python3 compatible #26112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domfarolino,
jdm,
mnot,
youennf and
yutakahirano
Hexcles
approved these changes
Oct 14, 2020
| subresource_path = "/" + os.path.relpath(__file__, base_path).replace('\\','/') | ||
| subresource_params = "?partition_id=" + partition_id + "&uuid=" + uuid + "&subresource_origin=" + subresource_origin + "&include_credentials=" + include_credentials | ||
| body = body.replace("SUBRESOURCE_PREFIX:", subresource_origin + subresource_path + subresource_params) | ||
| subresource_path = u"/" + os.path.relpath(isomorphic_decode(__file__), base_path).replace(u'\\', u'/') |
There was a problem hiding this comment.
Nit: it's better to make subresource_path binary in the first place, as all subsequent uses (along with subresource_params) are all binary.
There was a problem hiding this comment.
Code updated. Thank you!
| server_state = stash.take(uuid) or {u"test_failed": False} | ||
| if address_key in server_state and server_state[address_key] != isomorphic_decode(partition_id): | ||
| server_state[u"test_failed"] = True | ||
| server_state[address_key] = isomorphic_decode(partition_id) |
There was a problem hiding this comment.
Nit: can we directly store and compare the binary partition_id?
|
@Hexcles, are the updated changes okay? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.