-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wptrunner] Drop useAutomationExtension from Chrome options #26118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option has been removed since Chrome 85, which was the previous stable version, so it should be safe to remove it now. This stops ChromeDriver from complaining: [WARNING]: Deprecated chrome option is ignored: useAutomationExtension
wpt-pr-bot
added
infra
wptrunner
The automated test runner, commonly called through ./wpt run
labels
Oct 14, 2020
Of course I'm not going to review my own PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing tests on Chrome on Windows are a little suspect - do you think they're related?
No, I don't think so. They've been failing on other (definitely irrelevant) PRs. Filed #26131 |
stephenmcgruer
approved these changes
Oct 15, 2020
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
Usage of this option is deprecated and was dropped in #26118 Bug: 1139500 Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
Usage of this option is deprecated and was dropped in #26118 Bug: 1139500 Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Rakib Hasan <rmhasan@google.com> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818565}
scheib
pushed a commit
to scheib/chromium
that referenced
this pull request
Oct 19, 2020
Usage of this option is deprecated and was dropped in web-platform-tests/wpt#26118 Bug: 1139500 Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Rakib Hasan <rmhasan@google.com> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818565}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
Usage of this option is deprecated and was dropped in #26118 Bug: 1139500 Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Rakib Hasan <rmhasan@google.com> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818565}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 27, 2020
…' in chrome android browsers., a=testonly Automatic update from web-platform-tests Stop referencing 'useAutomationExtension' in chrome android browsers. Usage of this option is deprecated and was dropped in web-platform-tests/wpt#26118 Bug: 1139500 Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Rakib Hasan <rmhasan@google.com> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818565} -- wpt-commits: 75a04240a669feafba02302fdcf8b3d1ad1c2790 wpt-pr: 26171
sidvishnoi
pushed a commit
to sidvishnoi/gecko-webmonetization
that referenced
this pull request
Oct 27, 2020
…' in chrome android browsers., a=testonly Automatic update from web-platform-tests Stop referencing 'useAutomationExtension' in chrome android browsers. Usage of this option is deprecated and was dropped in web-platform-tests/wpt#26118 Bug: 1139500 Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Rakib Hasan <rmhasan@google.com> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818565} -- wpt-commits: 75a04240a669feafba02302fdcf8b3d1ad1c2790 wpt-pr: 26171
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Usage of this option is deprecated and was dropped in web-platform-tests/wpt#26118 Bug: 1139500 Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Rakib Hasan <rmhasan@google.com> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818565} GitOrigin-RevId: ce6e8b03dde3cb0027a247a8965c1534e0ba45d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option has been removed since Chrome 85, which was the previous
stable version, so it should be safe to remove it now.
This stops ChromeDriver from complaining:
[WARNING]: Deprecated chrome option is ignored: useAutomationExtension