Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wptrunner] Drop useAutomationExtension from Chrome options #26118

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented Oct 14, 2020

This option has been removed since Chrome 85, which was the previous
stable version, so it should be safe to remove it now.

This stops ChromeDriver from complaining:
[WARNING]: Deprecated chrome option is ignored: useAutomationExtension

This option has been removed since Chrome 85, which was the previous
stable version, so it should be safe to remove it now.

This stops ChromeDriver from complaining:
[WARNING]: Deprecated chrome option is ignored: useAutomationExtension
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Oct 14, 2020
@Hexcles
Copy link
Member Author

Hexcles commented Oct 14, 2020

Of course I'm not going to review my own PR :)

@Hexcles Hexcles assigned stephenmcgruer and unassigned Hexcles Oct 14, 2020
Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests on Chrome on Windows are a little suspect - do you think they're related?

@Hexcles
Copy link
Member Author

Hexcles commented Oct 15, 2020

No, I don't think so. They've been failing on other (definitely irrelevant) PRs. Filed #26131

@stephenmcgruer stephenmcgruer merged commit 09e3918 into master Oct 15, 2020
@stephenmcgruer stephenmcgruer deleted the remove-useAutomationExtension branch October 15, 2020 16:31
chromium-wpt-export-bot pushed a commit that referenced this pull request Oct 19, 2020
Usage of this option is deprecated and was dropped in
#26118

Bug: 1139500
Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c
chromium-wpt-export-bot pushed a commit that referenced this pull request Oct 19, 2020
Usage of this option is deprecated and was dropped in
#26118

Bug: 1139500
Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818565}
scheib pushed a commit to scheib/chromium that referenced this pull request Oct 19, 2020
Usage of this option is deprecated and was dropped in
web-platform-tests/wpt#26118

Bug: 1139500
Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818565}
chromium-wpt-export-bot pushed a commit that referenced this pull request Oct 19, 2020
Usage of this option is deprecated and was dropped in
#26118

Bug: 1139500
Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818565}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 27, 2020
…' in chrome android browsers., a=testonly

Automatic update from web-platform-tests
Stop referencing 'useAutomationExtension' in chrome android browsers.

Usage of this option is deprecated and was dropped in
web-platform-tests/wpt#26118

Bug: 1139500
Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818565}

--

wpt-commits: 75a04240a669feafba02302fdcf8b3d1ad1c2790
wpt-pr: 26171
sidvishnoi pushed a commit to sidvishnoi/gecko-webmonetization that referenced this pull request Oct 27, 2020
…' in chrome android browsers., a=testonly

Automatic update from web-platform-tests
Stop referencing 'useAutomationExtension' in chrome android browsers.

Usage of this option is deprecated and was dropped in
web-platform-tests/wpt#26118

Bug: 1139500
Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818565}

--

wpt-commits: 75a04240a669feafba02302fdcf8b3d1ad1c2790
wpt-pr: 26171
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
Usage of this option is deprecated and was dropped in
web-platform-tests/wpt#26118

Bug: 1139500
Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818565}
GitOrigin-RevId: ce6e8b03dde3cb0027a247a8965c1534e0ba45d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants