Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to commits pushed to epoch branches #26122

Merged
merged 1 commit into from Oct 15, 2020

Conversation

clopez
Copy link
Contributor

@clopez clopez commented Oct 14, 2020

This epoch/ branches are used to trigger the CI runs. However, identifying which commit of that branch triggered the run on a given day of the past is not trivial. There are several variables at play, like the timezone of the bot running the action which complicates this.

For example on #26097 I was unable to identify the commit that triggered the taskcluster run on epochs/daily for october 12.

So I think it is a good idea that we start tagging the commits pushed to this branches.

The format for the tags proposed here is the name of the branch with the date (year-month-day_hour). Example:

epochs/daily/2020-10-14_22H
epochs/six_hourly/2020-10-14_22H
epochs/three_hourly/2020-10-14_22H
epochs/twelve_hourly/2020-10-14_22H
epochs/weekly/2020-10-14_22H

This will be helpful to exactly identify which commits where pushed to the epoch/ branches on a given date.

* This will be helpful to exactly identify which commits where pushed
to the epoch/ branches on a given date. This branches are used to
trigger the CI runs, so this would help to match a failed run on
the CI on a given date with the hash of the commit.
@clopez
Copy link
Contributor Author

clopez commented Oct 14, 2020

BTW, I'm really only interested in tagging the daily and weekly ones.
If you think tagging the hourly ones is too much noise (too much tags) then I can modify this to only tag the weekly and dailies.

@clopez
Copy link
Contributor Author

clopez commented Oct 15, 2020

BTW, the failure on the CI seems totally unrelated to this commit

Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'm in favour of this, but should probably check with others? (ping @jgraham // @stephenmcgruer)

Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carlos, I think this is an improvement too! We have also felt the pain of finding which commits were epoch pushes, even on the three_hourly and six_hourly branches. We tag nearly ever commit today with the merge_pr_xyz setup (https://github.com/web-platform-tests/wpt/tags), so this will be no spammier than that...

@clopez
Copy link
Contributor Author

clopez commented Oct 15, 2020

Thanks!

@clopez clopez merged commit ac1a7dd into web-platform-tests:master Oct 15, 2020
foolip added a commit that referenced this pull request Mar 4, 2022
foolip added a commit that referenced this pull request Apr 9, 2022
This reverts #26122.

Document the epoch branches and how to debug them locally to remove the
need for these tags.

Fixes #26122.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants