[Gecko Bug 1675852] Part 3 - Use fallback 300px width and 150px height in ComputeSizeWithIntrinsicDimensions(). #26469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IntrinsicDimensions(). Per spec https://drafts.csswg.org/css-sizing-3/#intrinsic-contribution, for the replaced elements with no intrinsic size and no preferred aspect ratio, the fallback size is '300px' for the width and '150px' for the height, regardless of the writing-mode value. Without this patch, Firefox fails the last two subtests when the svg image has the vertical writing-mode with no intrinsic size and no aspect ratio. Both Chrome and Safari render all the subtests as 300x150. This patch fixed the last two subtests. Differential Revision: https://phabricator.services.mozilla.com/D96259 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1675852 gecko-commit: a49a06261673171b7d1f28012aff7e4d602efc6f gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec https://drafts.csswg.org/css-sizing-3/#intrinsic-contribution,
for the replaced elements with no intrinsic size and no preferred aspect
ratio, the fallback size is '300px' for the width and '150px' for the
height, regardless of the writing-mode value.
Without this patch, Firefox fails the last two subtests when the svg
image has the vertical writing-mode with no intrinsic size and no aspect
ratio. Both Chrome and Safari render all the subtests as 300x150.
This patch fixed the last two subtests.
Differential Revision: https://phabricator.services.mozilla.com/D96259
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1675852
gecko-commit: a49a06261673171b7d1f28012aff7e4d602efc6f
gecko-reviewers: emilio