Add test for timezonechange event #26555

FrankYFTang · 2020-11-17T19:11:27Z

Add tests to test whatwg/html#3047
WebDriver extension proposal in whatwg/html#3047
@stephenmcgruer @mathiasbynens @littledan

stephenmcgruer · 2020-11-17T19:22:50Z

FYI for WPT folk: This PR is blocked on an RFC for the new testdriver extension, which is in turn blocked on whatwg/html#3047 being updated. Frank is aware of this, and we aren't expecting anything to land until we get those two sorted.

FrankYFTang · 2020-11-17T22:56:56Z

FYI for WPT folk: This PR is blocked on an RFC for the new testdriver extension, which is in turn blocked on whatwg/html#3047 being updated. Frank is aware of this, and we aren't expecting anything to land until we get those two sorted.

Agree. I would like to get more other early feedback about the tests itself beside that issue from this PR.

FrankYFTang · 2020-11-17T23:00:06Z

@zbraniecki - Would you be able to find someone from Mozilla to support this move too?

annevk · 2020-11-18T07:59:52Z

To be clear, Mozilla is supportive of this effort. I'll defer to @jgraham et al for the technical details though.

stephenmcgruer · 2020-11-24T12:48:40Z

The RFC is now posted at web-platform-tests/rfcs#73, although it is still will not be able to land until whatwg/html#3047 at least has the webdriver text in the PR (preferably also that the PR is landed).

However we're making progress here, so I will start reviewing the WPT test infra side of this PR :)

docs/writing-tests/testdriver.md

tools/wptrunner/wptrunner/executors/protocol.py

tools/wptrunner/wptrunner/testdriver-extra.js

tools/wptrunner/wptrunner/executors/protocol.py

tools/wptrunner/wptrunner/executors/executorwebdriver.py

tools/wptrunner/wptrunner/executors/actions.py

stephenmcgruer

A few small nits, but this LGTM from the WPT infrastructure perspective, thanks!

I'm marking it request changes currently just until the RFC is merged, then I will switch to Approve.

docs/writing-tests/testdriver.md

infrastructure/testdriver/set_timezone.html

resources/testdriver.js

FrankYFTang · 2020-12-15T15:28:34Z

Updated. Please take another look

FrankYFTang · 2020-12-15T16:49:19Z

PTAL

This CL is NOT intended to be merge into chromium. I just want to use the chromium tryBot to validate the code is correct. The WPT PR is in #26555 Bug: 1144403 Change-Id: Ie3c062d1d9e59ee3f9087c7af99df7d2d29b056d

infrastructure/testdriver/set_timezone.html

resources/testdriver.js

tools/wptrunner/wptrunner/testdriver-extra.js

timezonechange/addeventlistener-timezonechange-fired.html

FrankYFTang · 2020-12-22T22:59:26Z

PTAL

mathiasbynens

LGTM % some minor suggestions

mathiasbynens · 2020-12-23T07:38:54Z

infrastructure/testdriver/set_timezone.html

+  let timeZone = "Asia/Taipei";
+  let timeZone2 = "Asia/Hong_Kong";


These are both GMT+8 (i.e. same local time). Can we use two timezones that actually differ to make the difference more clear? Say, 'Asia/Taipei' and 'Europe/Berlin' (GMT+1), or 'Pacific/Fakaofo' (GMT+13) as you use in the other tests.

Suggested change

let timeZone = "Asia/Taipei";

let timeZone2 = "Asia/Hong_Kong";

const timeZone = "Asia/Taipei";

const timeZone2 = "Pacific/Fakaofo";

WDYT?

mathiasbynens · 2020-12-23T07:42:22Z

service-workers/timezonechange/resources/service-worker-timezonechange.js

@@ -0,0 +1,14 @@
+self.addEventListener('message', function(e) {
+    const message = e.data;


nit: indentation should be 2 spaces

mathiasbynens · 2020-12-23T07:43:02Z

timezonechange/addeventlistener-timezonechange-fired.html

+    window.addEventListener('timezonechange', r);
+    window.test_driver.set_time_zone(newTimeZone);
+  }).then(e => {
+      assert_equals(defaultTimeZone(), newTimeZone);


nit: indentation

Suggested change

assert_equals(defaultTimeZone(), newTimeZone);

assert_equals(defaultTimeZone(), newTimeZone);

mathiasbynens · 2020-12-23T07:43:51Z

timezonechange/resources/shared-worker-timezonechange.js

+    port.postMessage("SUCCESS:" + timezone);
+  };
+  port.postMessage("READY:" + oldtimezone);  // (the html will change the timezone)
+}


nit:

Suggested change

}

};

mathiasbynens · 2020-12-23T07:43:58Z

timezonechange/resources/worker-timezonechange.js

+ontimezonechange = evt => {
+  let timezone = (new Intl.DateTimeFormat()).resolvedOptions().timeZone;
+  postMessage("SUCCESS:" + timezone);
+}


Suggested change

}

};

FrankYFTang · 2021-02-24T02:04:16Z

It is so hard to merge with the master via git command so I just did a git diff and then hand merge and hard push. Please review it again. Thanks

infrastructure/testdriver/set_timezone.html

timezonechange/resources/worker-timezonechange.js

wpt-pr-bot added docs infra service-workers testdriver.js timezonechange wg-sw wptrunner The automated test runner, commonly called through ./wpt run labels Nov 17, 2020

wpt-pr-bot assigned Hexcles Nov 17, 2020

wpt-pr-bot requested review from asutherland, Hexcles, jgraham, LukeZielinski, mkruisselbrink, sideshowbarker, stephenmcgruer and wanderview November 17, 2020 19:11

moz-wptsync-bot added the mozilla:gecko-blocked label Nov 17, 2020

stephenmcgruer assigned stephenmcgruer and unassigned Hexcles Nov 17, 2020

FrankYFTang mentioned this pull request Nov 17, 2020

Add a timezonechange event to Window/WorkerGlobalScope whatwg/html#3047

Open

mathiasbynens approved these changes Nov 18, 2020

View reviewed changes

stephenmcgruer assigned mathiasbynens Nov 24, 2020

mathiasbynens requested changes Nov 24, 2020

View reviewed changes

stephenmcgruer requested changes Nov 24, 2020

View reviewed changes

FrankYFTang force-pushed the add-set-timezone-with-tests branch from ff5f8f5 to 361b97a Compare December 15, 2020 15:24

FrankYFTang requested review from mathiasbynens and stephenmcgruer December 15, 2020 16:47

chromium-wpt-export-bot mentioned this pull request Dec 15, 2020

Prototype of the "Set Timezone WebDrive extension" #26375

Closed

sideshowbarker removed their request for review December 15, 2020 18:05

mathiasbynens requested changes Dec 21, 2020

View reviewed changes

mathiasbynens approved these changes Dec 23, 2020

View reviewed changes

Sync to the latest master

2b3590e

FrankYFTang force-pushed the add-set-timezone-with-tests branch from b318f8c to 2b3590e Compare February 24, 2021 02:02

FrankYFTang requested a review from mathiasbynens February 24, 2021 02:04

mathiasbynens approved these changes Feb 24, 2021

View reviewed changes

mathiasbynens reviewed Feb 24, 2021

View reviewed changes

infrastructure/testdriver/set_timezone.html Outdated Show resolved Hide resolved

Update infrastructure/testdriver/set_timezone.html

a17b177

mathiasbynens reviewed Feb 24, 2021

View reviewed changes

timezonechange/resources/worker-timezonechange.js Outdated Show resolved Hide resolved

timezonechange/resources/worker-timezonechange.js Outdated Show resolved Hide resolved

mathiasbynens and others added 3 commits February 24, 2021 09:56

Update timezonechange/resources/worker-timezonechange.js

1eda9bd

Update timezonechange/resources/worker-timezonechange.js

6112bdb

Fix MacOS issue

da14851

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for timezonechange event #26555

Add test for timezonechange event #26555

FrankYFTang commented Nov 17, 2020 •

edited

stephenmcgruer commented Nov 17, 2020 •

edited by mathiasbynens

FrankYFTang commented Nov 17, 2020

FrankYFTang commented Nov 17, 2020

annevk commented Nov 18, 2020

stephenmcgruer commented Nov 24, 2020

stephenmcgruer left a comment

FrankYFTang commented Dec 15, 2020

FrankYFTang commented Dec 15, 2020

FrankYFTang commented Dec 22, 2020

mathiasbynens left a comment

mathiasbynens Dec 23, 2020

mathiasbynens Dec 23, 2020

mathiasbynens Dec 23, 2020

mathiasbynens Dec 23, 2020

mathiasbynens Dec 23, 2020

FrankYFTang commented Feb 24, 2021

		let timeZone = "Asia/Taipei";
		let timeZone2 = "Asia/Hong_Kong";

		@@ -0,0 +1,14 @@
		self.addEventListener('message', function(e) {
		const message = e.data;

	assert_equals(defaultTimeZone(), newTimeZone);
	assert_equals(defaultTimeZone(), newTimeZone);

Add test for timezonechange event #26555

Are you sure you want to change the base?

Add test for timezonechange event #26555

Conversation

FrankYFTang commented Nov 17, 2020 • edited

stephenmcgruer commented Nov 17, 2020 • edited by mathiasbynens

FrankYFTang commented Nov 17, 2020

FrankYFTang commented Nov 17, 2020

annevk commented Nov 18, 2020

stephenmcgruer commented Nov 24, 2020

stephenmcgruer left a comment

Choose a reason for hiding this comment

FrankYFTang commented Dec 15, 2020

FrankYFTang commented Dec 15, 2020

FrankYFTang commented Dec 22, 2020

mathiasbynens left a comment

Choose a reason for hiding this comment

mathiasbynens Dec 23, 2020

Choose a reason for hiding this comment

mathiasbynens Dec 23, 2020

Choose a reason for hiding this comment

mathiasbynens Dec 23, 2020

Choose a reason for hiding this comment

mathiasbynens Dec 23, 2020

Choose a reason for hiding this comment

mathiasbynens Dec 23, 2020

Choose a reason for hiding this comment

FrankYFTang commented Feb 24, 2021

FrankYFTang commented Nov 17, 2020 •

edited

stephenmcgruer commented Nov 17, 2020 •

edited by mathiasbynens