Force other forced color properties at used value time #26603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 21, 2020
Forced colors should now happen at used value time. This change adjusts the used value of text-decoration-color, -internal-visited-text- decoration-color, column-rule-color, -internal-visited-column-rule-color, -webkit-tap-highlight-color, -webkit-text-emphasis-color, and -internal- visited-text-emphasis-color to take forced colors into account. No internal properties were needed since we only ever force these set of properties to currentColor in forced colors mode. The only remaining property to move to used value time is 'color'. Bug: 970285 Change-Id: Ica77609ce631f1768bdd52753535a484a32d3a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523664 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#829973}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2523664
branch
from
92bf921
to
451877b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forced colors should now happen at used value time. This change adjusts
the used value of text-decoration-color, -internal-visited-text-
decoration-color, column-rule-color, -internal-visited-column-rule-color,
-webkit-tap-highlight-color, -webkit-text-emphasis-color, and -internal-
visited-text-emphasis-color to take forced colors into account. No
internal properties were needed since we only ever force these set of
properties to currentColor in forced colors mode.
The only remaining property to move to used value time is 'color'.
Bug: 970285
Change-Id: Ica77609ce631f1768bdd52753535a484a32d3a3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523664
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829973}