Skip to content

/ wpt

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix echo-content-escaped.py again #26645

Merged
merged 3 commits into from Nov 25, 2020
Merged

Fix echo-content-escaped.py again #26645

merged 3 commits into from Nov 25, 2020

Conversation

@Hexcles
Copy link
Member

@Hexcles Hexcles commented Nov 25, 2020

The fix in #26615 only works in Py3.

This time we make it compatible with Py2 & Py3.
@Hexcles
Fix echo-content-escaped.py again
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8fba129 
The fix in #26615 only works in Py3.

This time we make it compatible with Py2 & Py3.
@Hexcles Hexcles requested a review from stephenmcgruer Nov 25, 2020
@wpt-pr-bot wpt-pr-bot added FileAPI wg-webapps labels Nov 25, 2020
@wpt-pr-bot wpt-pr-bot assigned mkruisselbrink Nov 25, 2020
@wpt-pr-bot wpt-pr-bot requested review from inexorabletash, jdm, mkruisselbrink and zqzhang Nov 25, 2020
@stephenmcgruer
stephenmcgruer approved these changes Nov 25, 2020
View changes
@Hexcles
Fix string literals
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c2c702f
@Hexcles
Copy link
Member Author

@Hexcles Hexcles commented Nov 25, 2020

Oops, I was trying to be smart to avoid unnecessary backslashes, but turns out you can't a raw string literal that ends with a backslash since that'd escape the quote...
@Hexcles
fixup
Loading status checks…
54433df
@Hexcles Hexcles merged commit c52e4b0 into master Nov 25, 2020
19 checks passed
19 checks passed
Azure Pipelines Build #20201125.34 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@Hexcles Hexcles deleted the fix-echo-content-escaped.py-1 branch Nov 25, 2020
@andreubotella
Copy link
Contributor

@andreubotella andreubotella commented Nov 26, 2020

In Python 3, this fix leaves the fallback case returning an int, causing every one of the FileAPI/file/send-file-form* tests to fail.
Hexcles added a commit that referenced this pull request Nov 26, 2020
@Hexcles
Fix echo-content-escaped.py for real
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4677cfe 
See #26645 (comment)
@Hexcles Hexcles mentioned this pull request Nov 26, 2020
Merged
Hexcles added a commit that referenced this pull request Nov 26, 2020
@Hexcles
Fix echo-content-escaped.py for real (#26655)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fcb3495 
See #26645 (comment)
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 4, 2020
@Hexcles @moz-wptsync-bot
Bug 1679437 [wpt PR 26655] - Fix echo-content-escaped.py for real, a=…
5d7eb17 
…testonly

Automatic update from web-platform-tests
Fix echo-content-escaped.py for real (#26655)

See web-platform-tests/wpt#26645 (comment)

--

wpt-commits: fcb3495f6321b32f607cabcbe0e63a918f48d348
wpt-pr: 26655
sidvishnoi pushed a commit to sidvishnoi/gecko-webmonetization that referenced this pull request Dec 10, 2020
@Hexcles @moz-wptsync-bot
Bug 1679437 [wpt PR 26655] - Fix echo-content-escaped.py for real, a=…
d2fefe8 
…testonly

Automatic update from web-platform-tests
Fix echo-content-escaped.py for real (#26655)

See web-platform-tests/wpt#26645 (comment)

--

wpt-commits: fcb3495f6321b32f607cabcbe0e63a918f48d348
wpt-pr: 26655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmcgruer stephenmcgruer

@inexorabletash inexorabletash

@jdm jdm

@mkruisselbrink mkruisselbrink

@zqzhang zqzhang

Assignees

@mkruisselbrink mkruisselbrink

Labels
FileAPI wg-webapps
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Hexcles @andreubotella @stephenmcgruer @mkruisselbrink @wpt-pr-bot