[Gecko Bug 1577530] Cache theming values from nsTextControlFrame correctly. #26931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that nsTextControlFrame might have a different used padding then the editing root block and thus the editing root's scrolled content, etc, because its padding doesn't match the style. This causes TextOverflow code to miscompute the content area size, which is sadness and causes the overflow markers to go over the padding box. The REFLOW_ROOT condition was introduced in bug 157846 and only partially takes care of the issue. This fix supersedes it, so we can remove it. Differential Revision: https://phabricator.services.mozilla.com/D99838 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1577530 gecko-commit: fd07538e12316562b6479e77af02c7b2b0f94d43 gecko-reviewers: heycam
wpt-pr-bot
approved these changes
Dec 16, 2020
… is specified, and this is covered once non-native-theme is enabled. MANUAL PUSH: Remove just-introduced orange test CLOSED TREE bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1577530 gecko-commit: 5ef9fa2708b2ba34de8a3674b328476fdf92908c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that nsTextControlFrame might have a different used padding
then the editing root block and thus the editing root's scrolled
content, etc, because its padding doesn't match the style.
This causes TextOverflow code to miscompute the content area size, which
is sadness and causes the overflow markers to go over the padding box.
The REFLOW_ROOT condition was introduced in bug 157846 and only
partially takes care of the issue. This fix supersedes it, so we can
remove it.
Differential Revision: https://phabricator.services.mozilla.com/D99838
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1577530
gecko-commit: fd07538e12316562b6479e77af02c7b2b0f94d43
gecko-reviewers: heycam