Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1577530] Cache theming values from nsTextControlFrame correctly. #26931

Merged
merged 2 commits into from Dec 17, 2020

Commits on Dec 16, 2020

  1. Cache theming values from nsTextControlFrame correctly.

    The issue is that nsTextControlFrame might have a different used padding
    then the editing root block and thus the editing root's scrolled
    content, etc, because its padding doesn't match the style.
    
    This causes TextOverflow code to miscompute the content area size, which
    is sadness and causes the overflow markers to go over the padding box.
    
    The REFLOW_ROOT condition was introduced in bug 157846 and only
    partially takes care of the issue. This fix supersedes it, so we can
    remove it.
    
    Differential Revision: https://phabricator.services.mozilla.com/D99838
    
    bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1577530
    gecko-commit: fd07538e12316562b6479e77af02c7b2b0f94d43
    gecko-reviewers: heycam
    emilio authored and moz-wptsync-bot committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    875430a View commit details
    Browse the repository at this point in the history
  2. Remove the test since some themes seem to do weird stuff when padding…

    … is specified, and this is covered once non-native-theme is enabled.
    
    MANUAL PUSH: Remove just-introduced orange test CLOSED TREE
    
    bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1577530
    gecko-commit: 5ef9fa2708b2ba34de8a3674b328476fdf92908c
    emilio authored and moz-wptsync-bot committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    88d8694 View commit details
    Browse the repository at this point in the history