Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update <link> pseudo selector WPTs #27178

Merged
merged 1 commit into from Jan 19, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 14, 2021

In these spec PRs [1][2], the <link> element will no longer match :link,
:visited, or :any-link, and it will no longer navigate the page when
clicked.

This patch also modifies the TestExpectations for one of the modified
tests navigation.sub.html. There was one test case which was
consistently timing out which I removed, which would stop the test from
timing out. However, there are an additional two test cases which time
out when run with run_web_tests.py but pass just fine with
run_wpt_tests.py. In addition, the flags passed to run_web_tests.py on
the trybots make it so that those two test cases which time out get
written to a failure file instead of making the whole test runner time
out, which would count as a failure in TestExpectations. Since the
default flags for run_web_tests.py make it an actual timeout according to
TestExpectations, I left the timeout expectation in there as well.

Hopefully this test can just be run with run_wpt_tests.py in the future
and we can get rid of this TestExpectation.

[1] whatwg/html#6269
[2] w3c/csswg-drafts#5839

Bug: 611093
Change-Id: I7234eb6024450e28c1ca6ec1ede7fdfc8f2ece52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628037
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844921}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@josepharhar josepharhar mentioned this pull request Jan 14, 2021
3 of 3 tasks complete
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2628037 branch from 899d052 to e17ff4d Jan 14, 2021
@@ -9,6 +9,17 @@ function getElementsByIds(ids) {
function testSelectorIdsMatch(selector, ids, testName) {
test(function(){
var elements = document.querySelectorAll(selector);
//assert_unreached('one: ' + JSON.stringify([...elements], null, 2) + '\n\ntwo: ' + JSON.stringify(getElementsByIds(ids), null, 2));

This comment has been minimized.

@domenic

domenic Jan 14, 2021
Member

These logs and comments should not be included, as they will fail lint.

This comment has been minimized.

@josepharhar

josepharhar Jan 15, 2021
Contributor

my bad, they're gone

test_follow_link(str);
});

async_test(function() {

This comment has been minimized.

@domenic

domenic Jan 14, 2021
Member

I'm not seeing this test fail in Firefox when I try it locally; are you?

This comment has been minimized.

@josepharhar

josepharhar Jan 15, 2021
Contributor

It was failing in firefox for me, but it was passing in safari which it shouldnt be, so I just changed it a bit - how about now?

@github-actions github-actions bot requested a deployment to wpt-preview-27178 Jan 14, 2021 Pending
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2628037 branch from e17ff4d to 899b59f Jan 14, 2021
@github-actions github-actions bot temporarily deployed to wpt-preview-27178 Jan 14, 2021 Inactive
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2628037 branch from 899b59f to 5bbd383 Jan 15, 2021
@github-actions github-actions bot temporarily deployed to wpt-preview-27178 Jan 15, 2021 Inactive
@josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Jan 15, 2021

ugh it looks like its flaky on firefox, which kinda makes sense since its a bit racy - I can't think of any better ideas of how to wait for the navigation to occur or not and pass when it doesn't occur...
I'll try to mess with it to find something that works.

@josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Jan 15, 2021

ugh it looks like its flaky on firefox, which kinda makes sense since its a bit racy - I can't think of any better ideas of how to wait for the navigation to occur or not and pass when it doesn't occur...
I'll try to mess with it to find something that works.

I think I figured it out, new patch on the way.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2628037 branch from 5bbd383 to 94e368f Jan 15, 2021
@github-actions github-actions bot temporarily deployed to wpt-preview-27178 Jan 15, 2021 Inactive
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2628037 branch from 94e368f to 085de67 Jan 15, 2021
@github-actions github-actions bot temporarily deployed to wpt-preview-27178 Jan 15, 2021 Inactive
In these spec PRs [1][2], the <link> element will no longer match :link,
:visited, or :any-link, and it will no longer navigate the page when
clicked.

This patch also modifies the TestExpectations for one of the modified
tests navigation.sub.html. There was one test case which was
consistently timing out which I removed, which would stop the test from
timing out. However, there are an additional two test cases which time
out when run with run_web_tests.py but pass just fine with
run_wpt_tests.py. In addition, the flags passed to run_web_tests.py on
the trybots make it so that those two test cases which time out get
written to a failure file instead of making the whole test runner time
out, which would count as a failure in TestExpectations. Since the
default flags for run_web_tests.py make it an actual timeout according to
TestExpectations, I left the timeout expectation in there as well.

Hopefully this test can just be run with run_wpt_tests.py in the future
and we can get rid of this TestExpectation.

[1] whatwg/html#6269
[2] w3c/csswg-drafts#5839

Bug: 611093
Change-Id: I7234eb6024450e28c1ca6ec1ede7fdfc8f2ece52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628037
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844921}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2628037 branch from 085de67 to d0e9420 Jan 19, 2021
@github-actions github-actions bot temporarily deployed to wpt-preview-27178 Jan 19, 2021 Inactive
@github-actions github-actions bot temporarily deployed to wpt-preview-27178 Jan 19, 2021 Inactive
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7fb7957 into master Jan 19, 2021
18 of 21 checks passed
18 of 21 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210119.39 failed
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview failed
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2628037 branch Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants