Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move FileAPI/blob to .js files #27368

Merged

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jan 28, 2021

This moves Blob tests which do not need document to be in global scope to .any.js tests. Tests that require document are now .window.js tests.

This is done in an effort to allow Deno to use these tests to validate it's implementation of Blob.

Copy link
Contributor

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

@lucacasonato
Copy link
Member Author

@mkruisselbrink I don't have write permission to merge here, so would be great if you could do that 😄.

@mkruisselbrink
Copy link
Contributor

Ah, sorry, will do.

@mkruisselbrink mkruisselbrink merged commit 3b27942 into web-platform-tests:master Feb 5, 2021
@lucacasonato lucacasonato deleted the FileAPI/blob-to-js branch February 5, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants