[python3] Remove a set of six uses from tools/
#27443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmcgruer
force-pushed
the
smcgruer/six-cleanup-1
branch
4 times, most recently
from
d1127d8
to
ceff724
Compare
The exception left behind was a set of ensure_text and ensure_binary calls, which are not trivially replaceable.
The exceptions were a set of ensure_text/ensure_string functions, which cannot be trivially replaced.
The exceptions are a set of ensure_* methods, which cannot be trivially replaced.
stephenmcgruer
force-pushed
the
smcgruer/six-cleanup-1
branch
from
ceff724
to
d3685f5
Compare
stephenmcgruer
changed the title
six in tools/lint/six uses from tools/
jgraham
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are Python3-only, this starts to tear out our usage of
six.Commits are organized by subdirectory, and this covers four of them:
lint/,wpt/,serve/andci/. In each I removed all uses ofsixexcept for theensure_*calls,which are not trivially replaceable.