Remove misleading contain-intrinsic-size prefix #27457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove misleading contain-intrinsic-size prefix since it is misleading. Instead use aspect-ratio prefix.
mrego
approved these changes
Feb 3, 2021
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 3, 2021
https://bugs.webkit.org/show_bug.cgi?id=221329 Patch by Rob Buis <rbuis@igalia.com> on 2021-02-03 Reviewed by Manuel Rego Casasnovas. LayoutTests/imported/w3c: Rename aspect-ratio/parsing/contain-intrinsic-size* since they deal with parsing aspect-ratio, not contain-intrinsic-size. Relevant WPT PR is web-platform-tests/wpt#27457. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-computed-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-computed-expected.txt. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-computed.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-computed.html. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-invalid-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-invalid-expected.txt. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-invalid.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-invalid.html. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-valid-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-valid-expected.txt. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-valid.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-valid.html. LayoutTests: Remove entry for test that passes. * TestExpectations: * platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/233646@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
yury-s
pushed a commit
to yury-s/webkit-http
that referenced
this pull request
Feb 3, 2021
https://bugs.webkit.org/show_bug.cgi?id=221329 Patch by Rob Buis <rbuis@igalia.com> on 2021-02-03 Reviewed by Manuel Rego Casasnovas. LayoutTests/imported/w3c: Rename aspect-ratio/parsing/contain-intrinsic-size* since they deal with parsing aspect-ratio, not contain-intrinsic-size. Relevant WPT PR is web-platform-tests/wpt#27457. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-computed-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-computed-expected.txt. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-computed.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-computed.html. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-invalid-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-invalid-expected.txt. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-invalid.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-invalid.html. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-valid-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-valid-expected.txt. * web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-valid.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-valid.html. LayoutTests: Remove entry for test that passes. * TestExpectations: * platform/glib/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@272315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove misleading contain-intrinsic-size prefix since it
is misleading. Instead use aspect-ratio prefix.