Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some py3 checks adjacent to virtualenv logic #27588

Merged
merged 1 commit into from Feb 12, 2021
Merged

Clean up some py3 checks adjacent to virtualenv logic #27588

merged 1 commit into from Feb 12, 2021

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 11, 2021

Spotted as part of #27377.

@github-actions github-actions bot temporarily deployed to wpt-preview-27588 February 11, 2021 08:38 Inactive
@jgraham
Copy link
Contributor

jgraham commented Feb 11, 2021 •
edited

ERROR: py36-flake8: commands failed

@stephenmcgruer
Copy link
Contributor

Specifically the error is:

./wpt/virtualenv.py:60:47: F821 undefined name 'pip_executable'

@foolip
Copy link
Member Author

foolip commented Feb 11, 2021

Oops, I'm glad we have tools that are smarter than me. I'll fix this.

@jgraham jgraham merged commit 050eae3 into master Feb 12, 2021
@jgraham jgraham deleted the foolip/py3only branch February 12, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

@LukeZielinski LukeZielinski Awaiting requested review from LukeZielinski

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

@stephenmcgruer stephenmcgruer Awaiting requested review from stephenmcgruer

Assignees

@jgraham jgraham

Labels
docs infra quic wpt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@foolip @jgraham @stephenmcgruer @wpt-pr-bot