Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fragmentainer overflow from children of monolithic content. #27701

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 19, 2021

Checking if the border box of a monolithic element can fit in the
current fragmentainer isn't enough. Children may overflow its border
box, and it's this size that we need to consider when determining
whether a monolithic element can fit in the current fragmentainer, or if
we have to push it to the next one.

Had to add a work-around to
fast/multicol/vertical-lr/balancing/balance-unbreakable.html to prevent
the (monolithic) IMG element (with alt text) in the test from messing
up. The broken image symbol got incorrectly aligned and therefore
incorrectly contributed to overflow. Reported crbug.com/1178743 for
this. Use a real image as a work-around. My first attempt was to switch
the IMG to writing-mode:horizontal-tb, but that messes up legacy column
balancing. Oh well...

Bug: 1178742
Change-Id: Iffbe55d53f32003ae58b574bb6a38745bb92d42e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2696632
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858109}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2696632 branch 2 times, most recently from e20ee3f to fccdb77 Feb 22, 2021
Checking if the border box of a monolithic element can fit in the
current fragmentainer isn't enough. Children may overflow its border
box, and it's this size that we need to consider when determining
whether a monolithic element can fit in the current fragmentainer, or if
we have to push it to the next one.

Had to add a work-around to
fast/multicol/vertical-lr/balancing/balance-unbreakable.html to prevent
the (monolithic) IMG element (with alt text) in the test from messing
up. The broken image symbol got incorrectly aligned and therefore
incorrectly contributed to overflow. Reported crbug.com/1178743 for
this. Use a real image as a work-around. My first attempt was to switch
the IMG to writing-mode:horizontal-tb, but that messes up legacy column
balancing. Oh well...

Bug: 1178742
Change-Id: Iffbe55d53f32003ae58b574bb6a38745bb92d42e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2696632
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858109}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2696632 branch from fccdb77 to 5095ed2 Feb 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 16d86f3 into master Feb 26, 2021
23 checks passed
23 checks passed
@github-actions
update-pr-preview
Details
@azure-pipelines
Azure Pipelines Build #20210226.34 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2696632 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants