Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fragmentainer overflow from children of monolithic content. #27701

Merged
merged 1 commit into from Feb 26, 2021

Commits on Feb 26, 2021

  1. Avoid fragmentainer overflow from children of monolithic content.

    Checking if the border box of a monolithic element can fit in the
    current fragmentainer isn't enough. Children may overflow its border
    box, and it's this size that we need to consider when determining
    whether a monolithic element can fit in the current fragmentainer, or if
    we have to push it to the next one.
    
    Had to add a work-around to
    fast/multicol/vertical-lr/balancing/balance-unbreakable.html to prevent
    the (monolithic) IMG element (with alt text) in the test from messing
    up. The broken image symbol got incorrectly aligned and therefore
    incorrectly contributed to overflow. Reported crbug.com/1178743 for
    this. Use a real image as a work-around. My first attempt was to switch
    the IMG to writing-mode:horizontal-tb, but that messes up legacy column
    balancing. Oh well...
    
    Bug: 1178742
    Change-Id: Iffbe55d53f32003ae58b574bb6a38745bb92d42e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2696632
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#858109}
    mstensho authored and chromium-wpt-export-bot committed Feb 26, 2021
    Copy the full SHA
    5095ed2 View commit details
    Browse the repository at this point in the history