Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a text-shadow and text-orientation: upright test #27770

Open
wants to merge 2 commits into
base: master
from

Conversation

@TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Feb 25, 2021

text-shadow-orientation-upright-001.html
reference/text-shadow-orientation-upright-001-ref.html

This test spun from
Issue 229211: text-shadow is drawn at the invalid position in vertical writing mode
on Chromium for Mac

The test and reference are coded in a way to elegantly work around subpixel positioning issue with Ahem font.

On my website:

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s76-text-shadow-orientation-upright-001.html

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/reference/text-shadow-orientation-upright-001-ref.html

@TalbotG TalbotG requested review from frivoal and fantasai Feb 25, 2021
@TalbotG TalbotG self-assigned this Feb 25, 2021
@wpt-pr-bot wpt-pr-bot requested review from kojiishi, plinss, r12a and upsuper Feb 25, 2021
@TalbotG TalbotG removed the request for review from plinss Feb 25, 2021
@fantasai
Copy link
Contributor

@fantasai fantasai commented Feb 25, 2021

I think your test is a bit more complicated than it needs to be again because you're trying to create a square. You could have, for example, used 4 different colored shadows off a single character and compared the result in vertical-rl to the same result in horizontal-tb. But the test is not incorrect.

Two options for you:

  • I can approve the test as-is. (Though I would recommend using green instead of purple and giving the div a red background.)
  • You can rewrite it using something like text-shadow: -1em 0 orange, 1em 0 blue, -1em purple, 1em yellow; margin: 1.5em against a single-character test div and, now that it's simpler and easier to understand, include a div for every writing mode combination.
@TalbotG
Copy link
Contributor Author

@TalbotG TalbotG commented Feb 25, 2021

4 different colored shadows off a single character and compared the result in vertical-rl to the same result in horizontal-tb

This flower-and-petals-like formation is indeed easier to understand and its design is more simple. I have created

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s76-text-shadow-orientation-upright-002.html

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/reference/text-shadow-orientation-upright-002-ref.html

and I will make the necessary github adjustments to this PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants