-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a text-shadow and text-orientation: upright test #27770
Added a text-shadow and text-orientation: upright test #27770
Conversation
I think your test is a bit more complicated than it needs to be again because you're trying to create a square. You could have, for example, used 4 different colored shadows off a single character and compared the result in vertical-rl to the same result in horizontal-tb. But the test is not incorrect. Two options for you:
|
This flower-and-petals-like formation is indeed easier to understand and its design is more simple. I have created and I will make the necessary github adjustments to this PR later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little bit concerned that the text will have anti-aliasing but the image reference won't, so probably a better reference would be to have a horizontal-mode copy of the text-shadow test code. But I'm not noticing any problems at the moment, so I will approve this and maybe the reference can be tweaked later if needed.
There is indeed a failure in Edge 96 due to anti-aliasing but only in Edge 96. I will revisit the reference and implement your proposal later this fall: it is on my to-do-list now. |
I almost forgot about this. A proposed correction and improvement is now in PR35337 |
text-shadow-orientation-upright-001.html
reference/text-shadow-orientation-upright-001-ref.html
This test spun from
Issue 229211: text-shadow is drawn at the invalid position in vertical writing mode
on Chromium for Mac
The test and reference are coded in a way to elegantly work around subpixel positioning issue with Ahem font.
On my website:
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/s76-text-shadow-orientation-upright-001.html
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/reference/text-shadow-orientation-upright-001-ref.html