Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLHttpRequest: response stream errors #27778

Merged
merged 2 commits into from
Mar 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// META: script=resources/test-helpers.sub.js

"use strict";

promise_test(async t => {
const url = "resources/fetch-request-xhr-sync-error-worker.js";
const scope = "resources/fetch-request-xhr-sync-iframe.html";

const registration = await service_worker_unregister_and_register(t, url, scope);
t.add_cleanup(() => registration.unregister());

await wait_for_state(t, registration.installing, 'activated');
const frame = await with_iframe(scope);
t.add_cleanup(() => frame.remove());

assert_throws_dom("NetworkError", frame.contentWindow.DOMException, () => frame.contentWindow.performSyncXHR("non-existent-stream-1.txt"));
assert_throws_dom("NetworkError", frame.contentWindow.DOMException, () => frame.contentWindow.performSyncXHR("non-existent-stream-2.txt"));
assert_throws_dom("NetworkError", frame.contentWindow.DOMException, () => frame.contentWindow.performSyncXHR("non-existent-stream-3.txt"));
}, "Verify synchronous XMLHttpRequest always throws a NetworkError for ReadableStream errors");
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
"use strict";

self.onfetch = event => {
if (event.request.url.endsWith("non-existent-stream-1.txt")) {
const rs1 = new ReadableStream();
event.respondWith(new Response(rs1));
rs1.cancel(1);
} else if (event.request.url.endsWith("non-existent-stream-2.txt")) {
const rs2 = new ReadableStream({
start(controller) { controller.error(1) }
});
event.respondWith(new Response(rs2));
} else if (event.request.url.endsWith("non-existent-stream-3.txt")) {
const rs3 = new ReadableStream({
pull(controller) { controller.error(1) }
});
event.respondWith(new Response(rs3));
}
};
23 changes: 23 additions & 0 deletions xhr/response-body-errors.any.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// This will transmit two chunks TEST_CHUNK and then garbage, which should result in an error.
const url = "/fetch/api/resources/bad-chunk-encoding.py?ms=1&count=2";

test(() => {
client = new XMLHttpRequest();
client.open("GET", url, false);
assert_throws_dom("NetworkError", () => client.send());
}, "Synchronous XMLHttpRequest should throw on bad chunk");

async_test(t => {
client = new XMLHttpRequest();
client.open("GET", url, true);
client.onreadystatechange = t.step_func(() => {
if (client.readyState === 3) {
assert_true(client.responseText.indexOf("TEST_CHUNK") !== -1);
}
});
client.onerror = t.step_func_done(() => {
assert_equals(client.responseText, "");
});
client.onload = t.unreached_func();
client.send();
}, "Asynchronous XMLHttpRequest should clear response on bad chunk");