Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Repaint when bgcolor animation is triggered" #27793

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 26, 2021

This reverts commit bbf753e8c7ec7c492f4436c2bdee81278309c4d2.

Reason for revert: Too much flakiness in blink_web_tests on Linux*

Recent failures:

Original change's description:

Repaint when bgcolor animation is triggered

Right now when a bgcolor animation/transition is triggered, such
as hovering over an element, we do not request a repaint of the
element and thus we cannot composite the bgcolor animation.

This CL fixes the problem by triggering a full repaint.

Bug: 1177320
Change-Id: I87dff5c11d109fc97f41c9b49e13b81613004281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698847
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857877}

Bug: 1177320
Change-Id: Ifabf8f703af522a6ea25aeac3e76926478a01610
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2719692
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Auto-Submit: Jiewei Qian <qjw@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#857947}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

This reverts commit bbf753e8c7ec7c492f4436c2bdee81278309c4d2.

Reason for revert: Too much flakiness in blink_web_tests on Linux*

Recent failures:
- https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/98274
- https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel/15065
- https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/21522

Original change's description:
> Repaint when bgcolor animation is triggered
>
> Right now when a bgcolor animation/transition is triggered, such
> as hovering over an element, we do not request a repaint of the
> element and thus we cannot composite the bgcolor animation.
>
> This CL fixes the problem by triggering a full repaint.
>
> Bug: 1177320
> Change-Id: I87dff5c11d109fc97f41c9b49e13b81613004281
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698847
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#857877}

Bug: 1177320
Change-Id: Ifabf8f703af522a6ea25aeac3e76926478a01610
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2719692
Reviewed-by: Jiewei Qian  <qjw@chromium.org>
Auto-Submit: Jiewei Qian  <qjw@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#857947}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2719692 branch from 5ce27a4 to ce24508 Feb 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cd176ca into master Feb 26, 2021
23 checks passed
23 checks passed
@github-actions
update-pr-preview
Details
@azure-pipelines
Azure Pipelines Build #20210226.10 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2719692 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants