[testharness.js] Do not wrap assert_any in expose_assert #27845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assert tracking code cannot handle nested asserts. It ends up both recording all the inner-asserts for assert_any (which is arguably correct but also looks confusing since some fail), as well as not properly recording the result for the `assert_any` itself (it overrides the last inner-assert results instead - even more confusing!) To workaround this quickly, do not wrap assert_any in the wrapper script. This means it will not show up in the asserts run, though its children will (but the last child will no longer have the wrong status). This isn't perfect, but it's a quick fix. Fixes #27824
jgraham
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assert tracking code cannot handle nested asserts. It ends up both
recording all the inner-asserts for assert_any (which is arguably
correct but also looks confusing since some fail), as well as not
properly recording the result for the
assert_anyitself (it overridesthe last inner-assert results instead - even more confusing!)
To workaround this quickly, do not wrap assert_any in the wrapper
script. This means it will not show up in the asserts run, though its
children will (but the last child will no longer have the wrong status).
This isn't perfect, but it's a quick fix.
Fixes #27824