content-visibility: Ensure to dirty continuations on force unlocks. #28478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures that we propagate a dirty bit from the continuations up the ancestor chain when we do a force unlock. In "regular" cases where we don't need to force unlock anything, we have layout containment which should prevent us from having continuations. R=ikilpatrick@chromium.org, kojii@chromium.org Fixed: 1197492 Change-Id: I2d8386e480c48c97e77875d3f8d73ad3d419c18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2822899 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#872454}
wpt-pr-bot
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that we propagate a dirty bit from the continuations
up the ancestor chain when we do a force unlock. In "regular" cases
where we don't need to force unlock anything, we have layout containment
which should prevent us from having continuations.
R=ikilpatrick@chromium.org, kojii@chromium.org
Fixed: 1197492
Change-Id: I2d8386e480c48c97e77875d3f8d73ad3d419c18c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2822899
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#872454}