Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[TablesNG] Width over percentage columns redistribution bugfix" #28835

Merged
merged 1 commit into from May 5, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 5, 2021

This reverts commit 06e4183b032c747402da655a0624ff83c9e85c73.

Reason for revert: https://crbug.com/1205135#c11

Original change's description:

[TablesNG] Width over percentage columns redistribution bugfix

Column width redistribution was incorrect if:

  • table width was wider than max columns width
  • all columns were percentage columns
  • column min width was wider than intrinsic percent width

Something like this would trigger it:
<td style="width:1%"> <- small percentage size
<div style=width:500px> <- large min width

Its a bit more complicated than that because of reverse percentage
width computation, you have to hit just the right ration of min/%.

The correct fix matches FF/Legacy:

  • distributed size is min-width + cell%/total% * excess width.

Bug: 1205135
Change-Id: I38187122e82ed7eeff2e4ec80ca45cfe8ef0e305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872538
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879205}

Bug: 1205135
Change-Id: I44771d1ad9e1fd2c7bbca089e1f509370a2e9a51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874388
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Owners-Override: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879286}

This reverts commit 06e4183b032c747402da655a0624ff83c9e85c73.

Reason for revert: https://crbug.com/1205135#c11

Original change's description:
> [TablesNG] Width over percentage columns redistribution bugfix
>
> Column width redistribution was incorrect if:
> - table width was wider than max columns width
> - all columns were percentage columns
> - column min width was wider than intrinsic percent width
>
> Something like this would trigger it:
>   <td style="width:1%">  <- small percentage size
>     <div style=width:500px> <- large min width
>
> Its a bit more complicated than that because of reverse percentage
> width computation, you have to hit just the right ration of min/%.
>
> The correct fix matches FF/Legacy:
> - distributed size is min-width + cell%/total% * excess width.
>
> Bug: 1205135
> Change-Id: I38187122e82ed7eeff2e4ec80ca45cfe8ef0e305
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872538
> Commit-Queue: Aleks Totic <atotic@chromium.org>
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#879205}

Bug: 1205135
Change-Id: I44771d1ad9e1fd2c7bbca089e1f509370a2e9a51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874388
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Owners-Override: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879286}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9118132 into master May 5, 2021
22 checks passed
22 checks passed
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@azure-pipelines
Azure Pipelines Build #20210505.29 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-3a0f475196 branch May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants