Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retry.py to Python 3 with type annotations #28895

Merged
merged 1 commit into from May 7, 2021
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented May 7, 2021

The type annotations here aren't very useful, but simple to do and
avoids the need to exempt this script from mypy later. It's been tested
with mypy locally.

Part of #28833.

The type annotations here aren't very useful, but simple to do and
avoids the need to exempt this script from mypy later. It's been tested
with mypy locally.

Part of #28833.
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although note this is called retry.py.

@foolip
Copy link
Member Author

foolip commented May 7, 2021

I'll fix retry.py in the commit message!

@foolip foolip changed the title Update rewrite.py to Python 3 with type annotations Update retry.py to Python 3 with type annotations May 7, 2021
@foolip foolip merged commit 4bc9779 into master May 7, 2021
@foolip foolip deleted the foolip/py3-retry branch May 7, 2021 16:45
foolip added a commit that referenced this pull request May 7, 2021
There's no issue here with mypy on Python 3.

Part of #28895.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 9, 2021
…lem in Python 2, a=testonly

Automatic update from web-platform-tests
Drop read_gzp workaround for a mypy problem in Python 2 (#28896)

There's no issue here with mypy on Python 3.

Part of web-platform-tests/wpt#28895.
--

wpt-commits: e953dffdcee1a2a276ea0b73c15e3c6e04d4683f
wpt-pr: 28896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants