[URL] Add expected failure tests for ASCII domains whose labels contain invalid IDNA #29008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest and
TimothyGu
TimothyGu
approved these changes
May 16, 2021
There was a problem hiding this comment.
This is technically tested already in url/resources/toascii.json, but a few test cases can't hurt. LGTM.
|
@achristensen07 It looks like this PR introduces some new errors in url-constructor.html for Safari, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns with whatwg/url#598
Some implementations may not be able to implement IDNA, or might fast-path ASCII domains, without taking in to account that domains are encoded by label. There may still be components which require IDNA validation, even if the domain is ASCII.