Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __future__ imports in tools/ #29211

Merged
merged 1 commit into from Jun 8, 2021
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Jun 4, 2021

The imports being removed are:

  • absolute_import, mandatory since 3.0
  • division, mandatory since 3.0
  • print_function, mandatory since 3.0
  • unicode_literals, mandatory since 3.0
  • with_statement, mandatory since 2.6

See https://docs.python.org/3/library/__future__.html for details.

The imports being removed are:
 - absolute_import, mandatory since 3.0
 - division, mandatory since 3.0
 - print_function, mandatory since 3.0
 - unicode_literals, mandatory since 3.0
 - with_statement, mandatory since 2.6

See https://docs.python.org/3/library/__future__.html for details.
@wpt-pr-bot wpt-pr-bot added infra lint manifest runner The web-based tools/runner/ serve wave wptrunner The automated test runner, commonly called through ./wpt run wptserve labels Jun 4, 2021
@wpt-pr-bot wpt-pr-bot requested a review from jgraham June 4, 2021 08:01
@gsnedders
Copy link
Member

It may just make sense to run pyupgrade on everything.

@foolip
Copy link
Member Author

foolip commented Jun 8, 2021

@gsnedders I've gone ahead and tried pyupgrade --py36-plus on all the files touched here and compared the changes made. The changes around __future__ are identical, but there's lots more. If you'd like to review/merge this PR I can send more using pyupgrade.

@jgraham jgraham merged commit b494ad8 into master Jun 8, 2021
@jgraham jgraham deleted the foolip/tools-has-no-future branch June 8, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra lint manifest runner The web-based tools/runner/ serve wave wptrunner The automated test runner, commonly called through ./wpt run wptserve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants