[Gecko Bug 1710605] Consistenly serialize list values as unquoted where possible #29441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously constructing some expected values as a list of StringNode objects due to make_value_node incorrectly calling make_node for list items. This is wrong as StringNode types can only be on the lhs of an expression (e.g. if os == "linux") but never on the right hand side (which is always a ValueNode or ListNode with ValueNode children). StringNodes are always serialized with quotes and this was causing values to flip flop between quoted and unquoted forms in some cases. Differential Revision: https://phabricator.services.mozilla.com/D115259 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1710605 gecko-commit: c12ba7e19c6f5bc427bb3c49639801c7200a262f gecko-reviewers: whimboo
Differential Revision: https://phabricator.services.mozilla.com/D118162 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1710605 gecko-commit: 4ee05dc03d18644efbc03f017c346b27580d6dda gecko-reviewers: whimboo
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously constructing some expected values as a list of
StringNode objects due to make_value_node incorrectly calling
make_node for list items. This is wrong as StringNode types can only
be on the lhs of an expression (e.g. if os == "linux") but never on
the right hand side (which is always a ValueNode or ListNode with ValueNode
children).
StringNodes are always serialized with quotes and this was causing
values to flip flop between quoted and unquoted forms in some cases.
Differential Revision: https://phabricator.services.mozilla.com/D115259
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1710605
gecko-commit: c12ba7e19c6f5bc427bb3c49639801c7200a262f
gecko-reviewers: whimboo