[Gecko Bug 1716963] Don't call cleanup from __del__ if it already ran #29465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Jun 23, 2021
Allow marionette users to opt out of __del__ doing any work by first explictly calling cleanup(). Differential Revision: https://phabricator.services.mozilla.com/D118147 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1716963 gecko-commit: 6b8537e78d74200b07502d0d40250601e5339b4a gecko-reviewers: webdriver-reviewers, whimboo
moz-wptsync-bot
force-pushed
the
gecko/1716963
branch
from
4a31c77
to
f8f25c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow marionette users to opt out of del doing any work by first
explictly calling cleanup().
Differential Revision: https://phabricator.services.mozilla.com/D118147
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1716963
gecko-commit: 02641f631413477ebab14d366fca815b0076704a
gecko-reviewers: webdriver-reviewers, whimboo