New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for scrolling to a fragment inside a shadow tree. #2953
Add a test for scrolling to a fragment inside a shadow tree. #2953
Conversation
As discussed on WICG/webcomponents#66 and whatwg/html#1192, the user agent should not use an element that has an ID exactly equal to decoded fragid or an anchor element with a name attribute exactly equal to fragid if the element inside a shadow tree as the indicated part of the document. WebKit nightly builds and Google Chrome Canary both passes the test.
Critic review: https://critic.hoppipolla.co.uk/r/6478 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Reviewers for this pull request are: @hayatoito, @kojiishi, @rniwa, @sideshowbarker, @sizuhiko, @TakayoshiKochi, and @yutak. |
<head> | ||
<title>Shadow DOM: The indicated part of the document should not match an element inside a shadow tree</title> | ||
<meta name="author" title="Ryosuke Niwa" href="mailto:rniwa@webkit.org"> | ||
<meta name="assert" content="An element insie a shadow tree should not be the indicated part of the document even if its ID is exactly equal to the decoded fragid or its name attribute is exactly equal to the fragid"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/insie/inside/
Other than a nit, LGTM |
Let's merge and I'll fix the nit. |
…tform-tests#2953) As discussed on WICG/webcomponents#66 and whatwg/html#1192, the user agent should not use an element that has an ID exactly equal to decoded fragid or an anchor element with a name attribute exactly equal to fragid if the element inside a shadow tree as the indicated part of the document. WebKit nightly builds and Google Chrome Canary both passes the test.
…tform-tests#2953) As discussed on WICG/webcomponents#66 and whatwg/html#1192, the user agent should not use an element that has an ID exactly equal to decoded fragid or an anchor element with a name attribute exactly equal to fragid if the element inside a shadow tree as the indicated part of the document. WebKit nightly builds and Google Chrome Canary both passes the test.
As discussed on WICG/webcomponents#66 and whatwg/html#1192, the user agent should not use an element that has an ID exactly equal to decoded fragid or an anchor element with a name attribute exactly equal to fragid if the element inside a shadow tree as the indicated part of the document.
WebKit nightly builds and Google Chrome Canary both passes the test.