<input type=time> with datalist triggers !IsValid() DCHECK #29530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 29, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2983437
branch
2 times, most recently
from
1ad0aa5
to
4ea4880
Compare
1) Only perform validity checks on truly plain text fields. We considered removing the check, but it still has value in terms of catching situations where the text field structure changes, which have occurred in the past and caused regressions. 2) Remove BrowserAccessibility::IsValid() from non-DCHECK builds. Bug: 1221781 NOTRY: true Change-Id: I5719fa84950f038f19ebe9c616db5946c52e0242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983437 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#897069}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2983437
branch
from
4ea4880
to
e8652a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We considered removing the check, but it still has value in terms
of catching situations where the text field structure changes,
which have occurred in the past and caused regressions.
Bug: 1221781
NOTRY: true
Change-Id: I5719fa84950f038f19ebe9c616db5946c52e0242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983437
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#897069}