[profiler] Attribute builtins to the nearest parent script #29908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 5, 2021
To ensure that builtins executed by cross-origin no-CORS script do not get included in traces, attribute them to the next valid caller script. This captures the notion of 'invoker' loosely defined in the spec. Bug: 956688 Change-Id: I7ff33be35b0162c7df25871ebc15323f2c2499ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3073352 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#909056}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3073352
branch
from
1a2b13e
to
9f4efc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that builtins executed by cross-origin no-CORS script do not
get included in traces, attribute them to the next valid caller script.
This captures the notion of 'invoker' loosely defined in the spec.
Bug: 956688
Change-Id: I7ff33be35b0162c7df25871ebc15323f2c2499ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3073352
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#909056}