Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout of openSXGInIframeAndWaitForMessage to 15 sec #29984

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 11, 2021

The timeout was extended from 3 sec to 10 sec by crrev.com/c/2694296.
But some tests are still flaky. So this CL extends the timeout to 15
sec.

Bug: 1087033
Change-Id: If93ae4941a8dbae4cebb7389f5dc1857481e4749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3088656
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#910686}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

The timeout was extended from 3 sec to 10 sec by crrev.com/c/2694296.
But some tests are still flaky. So this CL extends the timeout to 15
sec.

Bug: 1087033
Change-Id: If93ae4941a8dbae4cebb7389f5dc1857481e4749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3088656
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#910686}
@KyleJu
Copy link
Contributor

KyleJu commented Aug 13, 2021

Still experiencing timeout issues on Firefox. @past could you admin merge?

@past past merged commit 57fe7dd into master Aug 17, 2021
@past past deleted the chromium-export-cl-3088656 branch August 17, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants