[Gecko Bug 1725293] checkValidity() on <select required> returns true when <option value=> is moved in the dom #30148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…> is moved in the dom The new check should be still fast, since accessing selected index is trivial and Item() call is just accessing the element from an nsTArray. Differential Revision: https://phabricator.services.mozilla.com/D123371 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725293 gecko-commit: 5d85665d2784d62c2a4397521c1b17d4211834a4 gecko-reviewers: edgar
wpt-pr-bot
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new check should be still fast, since accessing selected index is trivial and Item() call is just accessing the element from an
nsTArray.
Differential Revision: https://phabricator.services.mozilla.com/D123371
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725293
gecko-commit: 5d85665d2784d62c2a4397521c1b17d4211834a4
gecko-reviewers: edgar