Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an IDL test set to the suite based on current document #3025

Merged
merged 5 commits into from May 26, 2016

Conversation

jimsch
Copy link
Contributor

@jimsch jimsch commented May 15, 2016

Note - I needed to comment out two lines. I don't know if this is an
error in the IDL in the document or something else.

Note - I needed to comment out two lines. I don't know if this is an
error in the IDL in the document or something else.
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6525

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@wpt-pr-bot
Copy link
Collaborator

Reviewers for this pull request are: @Ms2ger and @wafflespeanut.

@Ms2ger
Copy link
Contributor

Ms2ger commented May 17, 2016

It might be nice to have this running in workers as well; you can look at FileAPI/idlharness.{idl, html, worker.js} for inspiration. Let me know if you'd rather not do that.

@jimsch
Copy link
Contributor Author

jimsch commented May 17, 2016

Adding the same tests for workers makes sense. The pointer gave me the starting point. It may be that the documentation should be updated some time as it just talks about the html version and not the worker version.

@jimsch jimsch merged commit 9efcf4c into web-platform-tests:master May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants