[ResourceTiming]: Fix incorrect for-loop iteration #30296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 2, 2021
We were using `for (const [key, value] in Object.entries(thingy))` but that iterates the indices of the array returned by Object.entries We need to use `for (const [key, value] of Object.entries(thingy))` to get (key, value) pairs instead of (index,`undefined`) pairs. Bug: 1171767 Change-Id: I81848afe8dc31dced5363476a1367ce353f8a02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138594 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/main@{#917636}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3138594
branch
from
cf508bc
to
d535442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
for (const [key, value] in Object.entries(thingy))but that iterates the indices of the array returned by Object.entries
We need to use
for (const [key, value] of Object.entries(thingy))to get (key, value) pairs instead of (index,
undefined) pairs.Bug: 1171767
Change-Id: I81848afe8dc31dced5363476a1367ce353f8a02a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138594
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917636}