[WebTransport server] Make server-initiated bidirectional streams work #30795
Conversation
|
@nidhijaju Could you check this works around the problem you got? Also could you make sure this doesn't break other tests? @yutakahirano PTAL after this is confirmed to be working. |
|
Yes, I've checked that this workaround works well to temporarily solve the problem I had found. I also tested it with all the other existing tests we had, and it didn't break any of them. :) |
| @@ -187,6 +187,13 @@ def create_bidirectional_stream(self) -> int: | |||
| """ | |||
| stream_id = self._http.create_webtransport_stream( | |||
| session_id=self.session_id, is_unidirectional=False) | |||
| # TODO(bashi): Remove this workaround when aioquic supports receiving | |||
There was a problem hiding this comment.
This will be broken when the bug is fixed on aioquic. How about guarding the block with
if stream.frame_type is None:
or
if stream.frame_type is None and stream.session_id is None:
?
There was a problem hiding this comment.
I slightly prefer to assert because these asserts force us to remove these workarounds when we update aioquic.
|
Thank you @nidhijaju for checking and @yutakahirano for review! I'm going to merge this. |
|
The failure seems unrelated to this change. I'm going to merge this. |
No description provided.