Add tests for safelisting simple range headers from preflight #31058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Co-authored-by: Jake Archibald <jaffathecake@gmail.com>
annevk
reviewed
Oct 4, 2021
|
@annevk I added the test cases you suggested |
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Oct 5, 2021
The allowed format aligns with the values the browser uses when requesting media and resuming downloads. Tests: web-platform-tests/wpt#31058. Fixes #1310.
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Oct 11, 2021
The Fetch standard now safelists 'simple' range headers from preflight checks. (whatwg/fetch#1312) This CL also successfully runs against the new WPT suite (web-platform-tests/wpt#31058) I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0f1zQ4hjoyQ Bug: 1255711 Change-Id: I06ee27fec586950b7d45e3cba416df1b5090fa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190330 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/main@{#930108}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
The Fetch standard now safelists 'simple' range headers from preflight checks. (whatwg/fetch#1312) This CL also successfully runs against the new WPT suite (web-platform-tests/wpt#31058) I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0f1zQ4hjoyQ Bug: 1255711 Change-Id: I06ee27fec586950b7d45e3cba416df1b5090fa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190330 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/main@{#930108} NOKEYCHECK=True GitOrigin-RevId: 7b4dbc8d73cd09187b1501931141871f9d90b30d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch PR: whatwg/fetch#1312