New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync interfaces/ with @webref/idl 2.6.1 #31151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
approved these changes
Oct 7, 2021
foolip
requested changes
Oct 7, 2021
@@ -7,7 +7,8 @@ partial interface Navigator { | |||
[SecureContext, SameObject] readonly attribute Keyboard keyboard; | |||
}; | |||
|
|||
[SecureContext, Exposed=Window] interface Keyboard { | |||
[SecureContext, Exposed=Window] | |||
interface Keyboard : EventTarget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break the test unless dom.idl is added as a dependency first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've split it out into #31164.
foolip
added a commit
to foolip/wpt
that referenced
this pull request
Oct 8, 2021
This change is extracted from web-platform-tests#31151 and done separately because dom.idl is needed for EventTarget.
foolip
added a commit
to foolip/wpt
that referenced
this pull request
Oct 8, 2021
This change is extracted from web-platform-tests#31151 and done separately because dom.idl is needed for EventTarget.
github-actions
bot
force-pushed
the
actions/update-idl
branch
from
October 8, 2021 12:03
281302f
to
af137df
Compare
foolip
added a commit
to foolip/wpt
that referenced
this pull request
Oct 8, 2021
This change is extracted from web-platform-tests#31151 and done separately because dom.idl is needed for EventTarget.
Ms2ger
pushed a commit
that referenced
this pull request
Oct 8, 2021
This change is extracted from #31151 and done separately because dom.idl is needed for EventTarget.
foolip
approved these changes
Oct 8, 2021
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 14, 2021
…tonly Automatic update from web-platform-tests Update Keyboard Lock IDL and tests This change is extracted from web-platform-tests/wpt#31151 and done separately because dom.idl is needed for EventTarget. -- wpt-commits: 0bfbf52dcbd2433cd42a7ca43ab57c5b3e6f93a0 wpt-pr: 31164
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Oct 14, 2021
…tonly Automatic update from web-platform-tests Update Keyboard Lock IDL and tests This change is extracted from web-platform-tests/wpt#31151 and done separately because dom.idl is needed for EventTarget. -- wpt-commits: 0bfbf52dcbd2433cd42a7ca43ab57c5b3e6f93a0 wpt-pr: 31164
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
This change is extracted from web-platform-tests#31151 and done separately because dom.idl is needed for EventTarget.
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automated pull request updates interfaces/*.idl from @webref/idl 2.6.1.
Before merging, please check that any tests that depend on the updated IDL files still work.
If additional changes are needed, please manually create another PR based on this one.
See the workflow for how this pull request was created, and the README for how the IDL files in this directory are used.